Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for paramref elements in the XmlDocumentationProvider #6855

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 25, 2024

Summary of the changes (Less than 80 chars)

  • Add support for paramref elements in the XmlDocumentationProvider.

Closes #6848


  • I would have preferred to surround the name with backticks, but that wouldn't be consistent with the current handling of langword. This could be done for both in a later PR.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (acffe7b) 73.15% compared to head (3e829f2) 69.67%.
Report is 2 commits behind head on main.

Files Patch % Lines
...escriptors/Conventions/XmlDocumentationProvider.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6855      +/-   ##
==========================================
- Coverage   73.15%   69.67%   -3.48%     
==========================================
  Files        2499     2499              
  Lines      126162   126162              
==========================================
- Hits        92292    87907    -4385     
- Misses      33870    38255    +4385     
Flag Coverage Δ
unittests 69.67% <0.00%> (-3.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit cdfce1b into ChilliCream:main Feb 2, 2024
87 of 98 checks passed
@glen-84 glen-84 deleted the issue-6848 branch February 2, 2024 13:54
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paramref tags missing schema documentation
2 participants